Feature/access metadata details #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move tests for both to tests/test_metadata.py - MetadataSet.get_metadata_item renamed to __getitem__ allowing dict-style access
- involves injecting a reference to a RegionRegister and a TimeIntervalRegister when creating a Metadata object - then we can expose the list of region or interval names associated with the spatial and temporal resolution of the Metadata item (which describes a single dataset with observations for each of those regions and intervals)
…adata - API for accessing region and interval names goes via SectorModel.inputs or .outputs - code for accessing the metadata is exercised by EDMWrapper, approximating an integration test. - `smif -v run tests/fixtures/single_run/config/model.yaml` will run the model and log inputs and outputs with metadata a INFO level.
tomalrussell
force-pushed
the
feature/access-metadata-details
branch
from
6543c22
to
48aec54
Compare
- use SectorModelBuilder to produce SectorModel correctly
willu47
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Delivers #146028125]
Allows SectorModel to access the members of the temporal and spatial resolutions for each of the inputs and outputs defined in the model configuration.