Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy Implementation #3

Merged
merged 5 commits into from
Jan 21, 2023
Merged

Conversation

kiks12
Copy link
Contributor

@kiks12 kiks12 commented Jan 15, 2023

Used SQLAlchemy for the database as you said. This is my first time trying a pull request, hope it helps.

@nisnevich
Copy link
Owner

Hi there! Many thanks for your attention to the project! I'll get back to this next week when I have some time off work. If you could please resolve the conflicts according to the latest changes I'd appreciate. Cheers!

@kiks12
Copy link
Contributor Author

kiks12 commented Jan 15, 2023

HI! I resolved the conflicts already, nice to meet you sir!

@nisnevich nisnevich merged commit 1392e13 into nisnevich:main Jan 21, 2023
@nisnevich
Copy link
Owner

Thanks so much for the pull request! It really helps, I appreciate.

I wanted to share some notes with you what should be improved in the code. I'll fix it myself after merging because I'll keep going with more changes immediately after, just thought that might be helpful for you to know.

  1. Instead of passing the individual attributes of the row to the add_grant_proposal function, the entire object should be passed according to the definition.
  2. message_id is a separate column, it was added in the recent changes. id is autogenerated.
  3. raw SQL in reactions.py should be changed.
  4. some error handling and tests should be added.

Cheers!

@nisnevich
Copy link
Owner

nisnevich commented Mar 1, 2023

Hello @kiks12! As this project is affiliated with the Eco Community and I applied for a grant to fund its development, I would like to express my gratitude for your contributions through the pull request. Would you be open to receiving a token of appreciation in $ECO to your crypto wallet? Please reach me here to confirm, and then we can get in touch by other means.

@kiks12
Copy link
Contributor Author

kiks12 commented Mar 3, 2023

Hi there! I received your emails and I'm open to accept your token of appreciation.

@nisnevich
Copy link
Owner

@kiks12 just sent you 5000 $ECO. Thanks again for your input.

@kiks12
Copy link
Contributor Author

kiks12 commented Apr 8, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants