Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicer animation flow for dismiss on swipe #135

Merged
merged 1 commit into from
Aug 6, 2015

Conversation

Valodim
Copy link
Contributor

@Valodim Valodim commented Jul 14, 2015

...maybe "different" animation flow is a less opinionated term here.

snackbars are moved in from the bottom and are affixed to both screen edges (on non-tablet screens). I never quite liked how swiping the snackbar exposed the left or right edge, breaking its "full width, moved in from bottom" vibe. swiping it down to dismiss, as the guidelines say, is not very intuitive either.

this commit is a compromise which keeps side-swiping while keeping the edges fixed: swiping behavior is unchanged, but now only the content of the snackbar is moved, while the snackbar (i.e. its background) fades out but stays in place.

I tried different animations for actually dismissing the background afterwards, and fading it out the rest of the way felt better than moving it off the bottom of the screen for the swipe flow.

related note: your library has several advantages over the one from the support library, please keep maintaining it! 馃憤

@Valodim
Copy link
Contributor Author

Valodim commented Aug 6, 2015

ping?

if you like the old animation better, feel free to close the PR.

wmora added a commit that referenced this pull request Aug 6, 2015
nicer animation flow for dismiss on swipe
@wmora wmora merged commit 40674e7 into nispok:master Aug 6, 2015
@wmora
Copy link
Contributor

wmora commented Aug 6, 2015

:)

@wmora
Copy link
Contributor

wmora commented Aug 6, 2015

@Valodim sorry about the delay. I meant to publish this days ago. Just published it as version 2.11.0

@Valodim Valodim deleted the alt-swipe-anim branch August 7, 2015 09:27
Valodim added a commit to open-keychain/open-keychain that referenced this pull request Aug 7, 2015
This release merged our pull requests for round corners on tablet for top line,
and nicer dismiss-on-swipe animation.

nispok/snackbar#134
nispok/snackbar#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants