Locale on conditionalcolor scale

[trykyn]

When creating a color scale conditional formatting with explicit numbers, the locale seems to matter and invalid numbers get exported when using e.g. german number format

colorScaleFormatting.Thresholds[0].RangeType = RangeType.NUMBER; colorScaleFormatting.Thresholds[0].Value = -0.3; colorScaleFormatting.Thresholds[1].RangeType = RangeType.NUMBER; colorScaleFormatting.Thresholds[1].Value = 0.0; colorScaleFormatting.Thresholds[2].RangeType = RangeType.NUMBER; colorScaleFormatting.Thresholds[2].Value = 0.3;

Invalid output in the xml:
<conditionalFormatting sqref="E5"> <cfRule type="colorScale" dxfId="0" priority="1" aboveAverage="1"> <colorScale> <cfvo type="num" val="-0,3" gte="1" /> <cfvo type="num" val="0" gte="1" /> <cfvo type="num" val="0,3" gte="1" /> <color indexed="12" /> <color indexed="9" /> <color indexed="10" /> </colorScale> </cfRule> </conditionalFormatting>

[delreluca]

I haven't dug deep, but I think that the issue is the following parameterless ToString call:

npoi/ooxml/XSSF/UserModel/XSSFConditionalFormattingThreshold.cs

Line 101 in 58d6f45

cfvo.val = value.ToString();

[tonyqus]

What's your CultureInfo of the thread? German?

[delreluca]

Yes, Thread.CurrentThread.CurrentCulture is de-DE, but it happens with every culture that doesn't use . as decimal separator (e.g. fr-FR, it-IT, …).

So in the above mentioned line

npoi/ooxml/XSSF/UserModel/XSSFConditionalFormattingThreshold.cs

Line 101 in 58d6f45

cfvo.val = value.ToString();

replacing value.ToString() by value.ToString(CultureInfo.InvariantCulture) should ensure the correct format independent of the current culture.

Please note that the line in the getter

npoi/ooxml/XSSF/UserModel/XSSFConditionalFormattingThreshold.cs

Line 86 in 58d6f45

return Double.Parse(cfvo.val);

has to be adjusted as well to double.Parse(cfvo.val, CultureInfo.InvariantCulture) for consistency