New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helpers.ts #2

Open

iskandarreza wants to merge 1 commit into nitaiaharoni1:master from iskandarreza:text-filter-criteria-improvement

+1 −1

iskandarreza commented May 25, 2023

The current matchesCriteria method for criteria.text does not seem very effective.

  if (criteria.text) {
    const texts = Array.isArray(criteria.text) ? criteria.text : [criteria.text];
    if (!texts.includes(document.text)) {
      return false;
    }
  }

This means if criteria.text (or elements in an array passed in as it's value) is not an exact match to document.text, we'll get no results.

Unless that is by design, I propose the following minor change.


          Update helpers.ts

935612b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment