Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] case insensitive username #246

Merged
merged 16 commits into from Dec 18, 2018
Merged

[WIP] case insensitive username #246

merged 16 commits into from Dec 18, 2018

Conversation

nitely
Copy link
Owner

@nitely nitely commented Nov 25, 2018

fixes #178

todo:

  • data migration
  • case-insensitive mentions
  • make usernamelower on registrarion, login,
  • use user.st.nickname on templates
  • populate user.st.nickname on profile creation
  • case-insensitivity on private forum invitations
  • data migration tests
  • case-insensitive mentions tests
  • usernamelower on registrarion, login tests
  • populate user.st.nickname on profile creation tests
  • case-insensitivity on private forum invitations tests

@coveralls
Copy link

coveralls commented Nov 25, 2018

Coverage Status

Coverage increased (+0.07%) to 97.176% when pulling b10a54b on usernames_ci into 1bd3608 on master.

@nitely
Copy link
Owner Author

nitely commented Nov 25, 2018

This is a breaking change. Unless we make the setting off by default, but first I like case-insensitive (CI) usernames better and second the feature can be turned off without running into conflicts, that's not the case when turning it on.

@nitely nitely merged commit ac5a35e into master Dec 18, 2018
@nitely nitely deleted the usernames_ci branch December 18, 2018 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make usernames case-insensitive
2 participants