Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents bundling 'tests' dir in wheels, etc. #8

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

MaddieM4
Copy link
Contributor

This is important for contexts like Serverless, where the tests dir would collide with the consumer repo's tests dir.

See PyMySQL/PyMySQL#705 for more detail of this kind of problem.

This is important for contexts like Serverless, where the `tests` dir would collide with the consumer repo's `tests` dir.

See PyMySQL/PyMySQL#705 for more detail of this kind of problem.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4ecfd12 on campadrenalin:patch-1 into 178dbb3 on nitely:master.

@MaddieM4
Copy link
Contributor Author

Following up: I can confirm that this branch fixes the problem, by using this branch in my requirements.txt, now that it's published.

@nitely
Copy link
Owner

nitely commented Aug 31, 2018

Yeah, I agree. Removing graft tests in the Manifest file should do. graft docs should be removed as well.

@nitely nitely merged commit 6ffc9d0 into nitely:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants