Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing in main() #52

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Fix typing in main() #52

merged 1 commit into from
Jun 11, 2019

Conversation

sayanarijit
Copy link

No description provided.

@sayanarijit sayanarijit changed the title Update __init__.py Fix typing in main() Jun 10, 2019
@zupo
Copy link
Member

zupo commented Jun 10, 2019

Explain please?

@sayanarijit
Copy link
Author

https://www.python.org/dev/peps/pep-0484/#arbitrary-argument-lists-and-default-argument-values
We only need to declare the element type since the container type and key type is obvious.

zupo
zupo approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@zupo zupo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we have this elsewhere too. Check at least pyramid_openapi3 and pyramid_heroku too, pls.

@sayanarijit sayanarijit merged commit 8f01885 into master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zupo zupo zupo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayanarijit @zupo