Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various dope updates #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

various dope updates #32

wants to merge 2 commits into from

Conversation

noahehall
Copy link

@noahehall noahehall commented Apr 23, 2018

will update with changes soon as possible

@nitin42
Copy link
Owner

nitin42 commented Apr 25, 2018

This PR seems great. Thank you so much for your work. I'll review it fully this weekend!

@noahehall
Copy link
Author

noahehall commented Apr 26, 2018

Hi @nitin42

Please dont critically review just yet! posted just to make sure your aware this is coming down the pipeline.

I still need to:

  • squash the commits
  • update the failing tests
  • finish adding all of the new react 16 phases
  • remove the interval that checks for new performance measures and use a custom event as described here

as a side note - I did a demo of this awesome module for some colleagues and we all felt that presenting the data in a table would increase our ability to analyze and interpret the results.

Thus this PR will also add an ability to to switch between the pie/donut charts to a table.

@nitin42
Copy link
Owner

nitin42 commented Apr 27, 2018

That's awesome!

@nitin42
Copy link
Owner

nitin42 commented Jul 4, 2018

Hey, just wanted to check-in! Any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants