Add the option to show console logging in the terminal #4
Conversation
jcgertig
commented
Jul 7, 2017
jcgertig
commented
|
GREAT WORK !!!!!! @jcgertig . Thank you so much for adding this. I will definitely merge this later because I am currently working on this |
|
Thank you so much for this!! |
| @@ -1,44 +1,41 @@ | |||
| .container-main { | |||
| .terminal-container-wrapper { | |||
package.json
Outdated
| @@ -29,7 +31,8 @@ | |||
| "scripts": { | |||
| "start": "NODE_ENV=development ./node_modules/.bin/webpack-dev-server --watch", | |||
| "build": "NODE_ENV=production ./node_modules/.bin/webpack --config ./webpack.config.js --display-max-modules 0", | |||
| "prepublish": "npm run build" | |||
| "prepublish": "npm run build", | |||
| "dev": "cross-env NODE_ENV=development ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --config ./test/webpack.config.js --progress --colors --content-base test/" | |||
There was a problem hiding this comment.
I've added a starter kit (covers local dev server and webpack config). So this will not be required 😄
test/index.html
Outdated
| @@ -0,0 +1,10 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I've created a webpack config for dev env and it includes the plugins html-webpack-template and html-webpack-plugin. So we don't need a html file anymore to test the project locally !!
test/webpack.config.js
Outdated
| @@ -0,0 +1,30 @@ | |||
| const webpack = require('webpack'); | |||
There was a problem hiding this comment.
I've created a new config from scratch. You can make changes in that file.
|
@nitin42 sounds good go ahead and add your starter and html-webpack-plugin and I will deal with merge conflicts |
|
@nitin42 can I ask what editor you use? |
|
What happened ? Something related to indentation and code format ? |
# Conflicts: # components/Terminal.js # package.json
|
You use tab characters not spaces that's why I was wondering but I dropped in a editor config so if your editor supports it or has a plugin for it I would suggest using it |
| description={{ 'open-google': 'opens google.com', showmsg: 'shows a message', alert: 'alert', popup: 'alert' }} | ||
| commands={{ | ||
| 'open-google': () => window.open("https://www.google.com/", "_blank"), | ||
| showmsg: this.showMsg, |
| ## Customisation | ||
|
|
||
| Use | ||
|
|
||
| * prop `color` to change the color of the text. | ||
| * prop `backgroundColor` to change the background. | ||
| * prop `barColor` to change the color of bar. | ||
| * prop `prompt` to change the prompt (`$`) color. | ||
| * prop `prompt` to change the prompt (`>`) color. |
| .print { | ||
| margin-bottom: 10px; | ||
| line-height: 21px; | ||
| .terminal-output-line { |
There was a problem hiding this comment.
Its so symmetrical comparing to my nomenclature! Thanks
|
Thank you so much for the PR! 😄 |
