Added redigo based IAttackStore implementation #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jul 7, 2019
models/db.go
Outdated
| } | ||
| if attackIDs, ok := res.([]interface{}); !ok { | ||
| return nil | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (from golint)
models/db.go
Outdated
|
|
||
| if err := json.Unmarshal(res.([]byte), &attack); err != nil { | ||
| return nil | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (from golint)
added 2 commits
July 6, 2019 21:41
…com/nitishm/vegeta-server into nitishm/enhancement/22/iattackstore
golangcibot
reviewed
Jul 7, 2019
models/db.go
Outdated
| } | ||
|
|
||
| func (r Redis) GetAll(filterParams FilterParams) []AttackDetails { | ||
| var attacks []AttackDetails |
There was a problem hiding this comment.
Consider preallocating attacks (from prealloc)
|
Fixes #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a redigo based redis store attack and report