app.nit: fix issues in examples and calculator #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… root_window Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
…calls Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
privat
approved these changes
Nov 14, 2017
privat
added a commit
that referenced
this pull request
Nov 20, 2017
- Fix missing Makefile dependencies by correctly using the -m options in calls to nitls. It would work without the -m for simple programs but misses some files when there are conditional importations. - Fix crash in `http_request_example` by updating the latest app.nit UI API from #2547. Closes #2577. - Compile the scientific desktop variant of the calculator with the `all` rule. Pull-Request: #2579
privat
added a commit
that referenced
this pull request
Nov 21, 2017
- Fix missing Makefile dependencies by correctly using the -m options in calls to nitls. It would work without the -m for simple programs but misses some files when there are conditional importations. - Fix crash in `http_request_example` by updating the latest app.nit UI API from #2547. Closes #2577. - Compile the scientific desktop variant of the calculator with the `all` rule. Pull-Request: #2579
privat
added a commit
that referenced
this pull request
Nov 22, 2017
- Fix missing Makefile dependencies by correctly using the -m options in calls to nitls. It would work without the -m for simple programs but misses some files when there are conditional importations. - Fix crash in `http_request_example` by updating the latest app.nit UI API from #2547. Closes #2577. - Compile the scientific desktop variant of the calculator with the `all` rule. Pull-Request: #2579
privat
added a commit
that referenced
this pull request
Nov 23, 2017
- Fix missing Makefile dependencies by correctly using the -m options in calls to nitls. It would work without the -m for simple programs but misses some files when there are conditional importations. - Fix crash in `http_request_example` by updating the latest app.nit UI API from #2547. Closes #2577. - Compile the scientific desktop variant of the calculator with the `all` rule. Pull-Request: #2579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_request_exampleby updating the latest app.nit UI API from app.nit: easier root window selection and other misc improvements #2547. Closes http_request_example.nit fails with "assertion failed" #2577.allrule.