modelize: broken mproperties can have definitions #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so, when keep-going is activated, mproperty.intro and other related services wont crashes. Thus fixes nitlang#2599 moreover, the mpropdefs attempts are registered in the model (if one need them?). This might however add some unexpected effects (one does not simply add broken entities into mordor^Wmodel). TODO: the same thing with classes? Signed-off-by: Jean Privat <jean@pryen.org>
|
test this please |
2 similar comments
|
test this please |
|
test this please |
Morriar
approved these changes
Jul 15, 2019
|
That's one of the problem with Exceptions could be useful here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so, when keep-going is activated, mproperty.intro and other related services wont crashes.
Thus fixes #2599
moreover, the mpropdefs attempts are registered in the model (if one need them?).
This might however add some unexpected effects (one does not simply add broken entities into mordor^Wmodel).
TODO: the same thing with classes?