Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run: 'Movie' object has no attribute 'load' #10

Closed
Wohlstand opened this issue Jun 4, 2019 · 5 comments
Closed

Can't run: 'Movie' object has no attribute 'load' #10

Wohlstand opened this issue Jun 4, 2019 · 5 comments

Comments

@Wohlstand
Copy link

Tried for a quick test run the movie, however, script has an error and not working:

~/_git_repos/ascii-telnet-server $ python3.6 ascii_telnet_server.py -f ./movies/badapple.txt --stdout -S 80x24 -s 80x25 -r 60
Traceback (most recent call last):
  File "ascii_telnet_server.py", line 199, in <module>
    run_std_out(options.filename, framerate, screen_width, screen_height, frame_width, frame_height)
  File "ascii_telnet_server.py", line 110, in run_std_out
    movie.load(filepath)
AttributeError: 'Movie' object has no attribute 'load'
@ZenithalHourlyRate
Copy link
Contributor

Fast (worst) solution
git reset 5b69116

I tested that it can run the movie well.
No offense to the excellent work done by nitram509.

Debug details:
It seems that nitram509 has removed Movie.load and changed some variable names(from _frame_height/_frame_width to frame_height/frame_width) in classs Movie, thus I can not just simply add Movie.load back from old codes.

Note that Movie.load is used twice, in ascii_telnet_server.run_std_out and ascii_telnet/ascii_server.py, line 65. Changes should take place at both places.

@nitram509
Copy link
Owner

hi all,
indeed I did started some refactoring an MASTER branch is broken as of now.
this is odd, I admit.
I will roll back my latest changed and derive my work on a DEVELOPMENT branch
and fix MASTER again.

Sorry for the confusion and thank you all for your feedback 👍

Regards
Martin

@nitram509
Copy link
Owner

done.
you might want to check again, @Wohlstand ?

@Wohlstand
Copy link
Author

Will check once I'll reach my workplace

@Wohlstand
Copy link
Author

Yes, it now works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants