-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme with warnings on serialization #10
Comments
On further investigation, it seems that most libraries (de)serialize in a similar manner to this one, as a sort of standard set by |
Thanks for your feedback. I'll add short notice in the README, to make this pitfall more explicit. |
Thanks, but to clarify, I meant specifically that the data itself is modified in addition to encoding. To use your example
Note the hex signature, and the lack of hex packet prefixes denoting the packet size. Meanwhile, a URL-safe Base64 decode looks like this:
Is this a different variant that is spec'd somewhere, or just to match what |
As far as I can tell, they're not. You seem to have some extra line prefixes in addition (packet headers for annotation). This resulted in hours of debugging for us because we assumed we could use the serialized data across lanugages/libaries by URL and Base64 decoding macaroons.
It would be useful to future devs if there was some sort of warning in the readme.
The text was updated successfully, but these errors were encountered: