Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awstf): Add SQL Database support #626

Merged
merged 3 commits into from
Jun 27, 2024
Merged

feat(awstf): Add SQL Database support #626

merged 3 commits into from
Jun 27, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jun 14, 2024

Add SQL database deployment support the the AWS terraform provider.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (8009fe8) to head (d27d3a3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   49.21%   49.21%           
=======================================
  Files          23       23           
  Lines        3233     3233           
=======================================
  Hits         1591     1591           
  Misses       1537     1537           
  Partials      105      105           
Flag Coverage Δ
aws 43.75% <ø> (ø)
azure 53.29% <ø> (ø)
core 77.88% <ø> (ø)
gcp 47.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not trigger the code build jobs after 2nd try.

Steps:
Deploy using prisma or drizzle.
Add a 2nd migration
Deploy again

I'll make a PR

davemooreuws

This comment was marked as resolved.

Co-authored-by: Jye Cusch<jye.cusch@gmail.com>
@tjholm tjholm merged commit 7bd10df into main Jun 27, 2024
4 checks passed
@tjholm tjholm deleted the awstf-sql-support branch June 27, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants