Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to name a generated release #68

Closed
choptastic opened this issue Apr 22, 2014 · 3 comments
Closed

Add the ability to name a generated release #68

choptastic opened this issue Apr 22, 2014 · 3 comments

Comments

@choptastic
Copy link
Member

By default, a generated release is called 'nitrogen', creates a directory called 'nitrogen', and uses a 'nitrogen.app.src' and all the other specifics. But it's more common that a user will want to create an app that uses nitrogen, not one that's necessarily named nitrogen. As such, being able to create a new project using something similar to rebar's or chicagoboss's approach with make rel_yaws PROJECT=myapp, which would properly name files and also ensure that one doesn't need to create a custom config handler for this.

Food for thought.

@fooflare
Copy link
Contributor

As always, I am one step behind and I didn't realize about the default filenames of the generated project, until you closed this issue.
I modified the Makefile to generate the 'site/src' files with the name of the project and replace inside them the name of the modules. And of course, the configuration files to modify the server and application name, as well as the module of the the server handler renamed in 'site/src'.
As example, a project called example_org would be like:

files

Well, I don't know if I explained it correctly, sometimes it is difficult to make things understandable.
What do you think? Would you be interested in these changes? I created a branch in my fork called replace_default_nitrogen with the changes in the Makefile if you want to have a look or try it.

I forgot one thing, I tried it just in Linux, but I suppose in OSX should work (I can't check it, sorry). And for Windows (I haven't yet tried to build Nitrogen in Windows)... But when I have some time, I will have a look if I can do it.

@choptastic
Copy link
Member Author

I actually would be interested in these changes, however, the reason I
didn't build this myself was due to the default config handler in
nitrogen_core which relies on the name of the application being "nitrogen".

The way you're doing it here is the correct way to do it, but it would
require cleaning up the config handler so that it properly handles the name
change.

The solution might be as simple as just changing the config handler to rely
on nitrogen_core, rather than your own application, and that would also
require updating the app.config file to use nitrogen_core as well, but I'm
honestly on the fence about the best way to do it.

On Wed, Aug 20, 2014 at 11:03 AM, fooflare notifications@github.com wrote:

As always, I am one step behind and I didn't realize about the default
filenames of the generated project, until you closed this issue.
I modified the Makefile to generate the 'site/src' files with the name of
the project and replace inside them the name of the modules. And of course,
the configuration files to modify the server and application name, as well
as the module of the the server handler renamed in 'site/src'.
As example, a project called example_org would be like:

[image: files]
https://cloud.githubusercontent.com/assets/1466443/3983751/2d00310c-2882-11e4-90bd-47f81e2b5aeb.png

Well, I don't know if I explained it correctly, sometimes it is difficult
to make things understandable.
What do you think? Would you be interested in these changes? I created a
branch in my fork called replace_default_nitrogen with the changes in the
Makefile if you want to have a look or try it.


Reply to this email directly or view it on GitHub
#68 (comment).

Jesse Gumm
Owner, Sigma Star Systems
414.940.4866 || sigma-star.com || @jessegumm

@fooflare
Copy link
Contributor

Yeah, that seems to be a bit more difficult. I haven't enough knowledge about nitrogen right now, so I feel like a monkey pressing buttons and trying to be lucky... But it was just the first try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants