Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cowboy to v1.0.0 #38

Merged
merged 2 commits into from
Oct 2, 2014
Merged

Update cowboy to v1.0.0 #38

merged 2 commits into from
Oct 2, 2014

Conversation

fooflare
Copy link
Contributor

@fooflare fooflare commented Oct 1, 2014

Hi Jesse,
I've been testing cowboy v1.0.0 with Nitrogen project webpage and seems it works fine just with this little change. I make this pull request if you are interested in updating it now. If so, I have made the update too in my nitrogen fork, but I'll wait to pull request until you decide if you really want to change it in simple_bridge.

@choptastic
Copy link
Member

So funny! This is also something I was working on last night. I'll merge in your changes here, but there are a few missing pieces (particularly with properly handling the fact that cowboy_req:stream_body was removed in Cowboy 1.0.

But I like it, and you did the mimetypes stuff, which I completely forgot about :)

@choptastic
Copy link
Member

No need to update the PR or make the PR for Nitrogen. I have the deps updated locally, I'm just finishing the compatibility stuff and testing with file uploads, which should all be ready today to prepare another beta release.

@fooflare
Copy link
Contributor Author

fooflare commented Oct 1, 2014

Oh, I think I'll have to ask before in the future :)
I realized that there were some things I was missing, but as always late :(
One thing I crashed with this PR was autocomplete textbox (again), I am not sure what changed in json from cowboy. I have a strange fight with this widget. I tried to fix it but the only thing I got was a headache.

@choptastic
Copy link
Member

No need to ask, it's pretty rare to have this kind of collision.

The textbox_autocomplete is a little nasty, but I think it's made a
little less so with the websocket update. Either way, I'll play with it.

Very likely, I'll end up reworking it in a non-backwards compatible way,
since it is a little goofy, what with its reliance on json and whatnot.

-Jesse

On Wed, Oct 1, 2014 at 11:00 AM, fooflare notifications@github.com wrote:

Oh, I think I'll have to ask before in the future :)
I realized that there were some things I was missing, but as always late :(
One thing I crashed with this PR was autocomplete textbox (again), I am
not sure what changed in json from cowboy. I have a strange fight with this
widget. I tried to fix it but the only thing I got was a headache.


Reply to this email directly or view it on GitHub
#38 (comment).

Jesse Gumm
Owner, Sigma Star Systems
414.940.4866 || sigma-star.com || @jessegumm

@choptastic choptastic merged commit a2ebe9f into nitrogen:master Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants