Skip to content

Commit

Permalink
Callback: removing args from task_fields from Sumologic and Splunk pl…
Browse files Browse the repository at this point in the history
…ugin(ansible#63527)

CVE-2019-14864 Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs

Fixes ansible#63522

Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
  • Loading branch information
poblahblahblah authored and Akasurde committed Nov 1, 2019
1 parent 56d5fd3 commit c76e074
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
@@ -0,0 +1,2 @@
bugfixes:
- '**security issue** - Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs (CVE-2019-14864)'
3 changes: 3 additions & 0 deletions lib/ansible/plugins/callback/splunk.py
Expand Up @@ -98,6 +98,9 @@ def send_event(self, url, authtoken, state, result, runtime):
else:
ansible_role = None

if 'args' in result._task_fields:
del result._task_fields['args']

data = {}
data['uuid'] = result._task._uuid
data['session'] = self.session
Expand Down
3 changes: 3 additions & 0 deletions lib/ansible/plugins/callback/sumologic.py
Expand Up @@ -89,6 +89,9 @@ def send_event(self, url, state, result, runtime):
else:
ansible_role = None

if 'args' in result._task_fields:
del result._task_fields['args']

data = {}
data['uuid'] = result._task._uuid
data['session'] = self.session
Expand Down

0 comments on commit c76e074

Please sign in to comment.