Paxml presents errors occurring during 'onExit' as the cause of failure of the scenario.

[jjjasper]

currently I have:

(53) Exception(s) occurred while calling the onExit() method(s) on paxml execution listener(s). See the error log for details.

Where the underlying cause is

2015-04-01 10:02:29,410 [ERROR] EvaLevel2WithLimitAmountsTest@9 > CorporateTestData@304 > sql
Exception in AbstractTag.execute.
org.paxml.core.PaxmlRuntimeException: org.paxml.core.PaxmlRuntimeException: org.paxml.core.PaxmlRuntimeException: org.paxml.core.PaxmlRuntimeException: Cannot execute sql: INSERT INTO USER_DATA (ID,NAME,FIRSTNAME,LASTNAME,EMAIL,COUNTRY,CUSTOMERID,LANGUAGE,LASTLOGIN,STATUS) VALUES (USER_ID_SEQ.nextval, '1.163813E7', 'Corporate', 'Administrator', NULL, 'NL', '1.163813E7', 'nl', TO_DATE('30-06-2009 17:00:39','DD-MM-YYYY HH24:MI:SS'), '1')
at org.paxml.tag.AbstractTag.execute(AbstractTag.java:161)
at org.paxml.tag.AbstractTag.executeChild(AbstractTag.java:260)
at org.paxml.tag.AbstractTag.executeChildren(AbstractTag.java:241)
[...]
at org.paxml.tag.sql.SqlTag$1.update(SqlTag.java:195)
at org.paxml.tag.sql.SqlTag.executeSql(SqlTag.java:270)
... 45 more
Caused by: java.sql.SQLException: ORA-01013: user requested cancel of current operation
at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:331)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:288)
at oracle.jdbc.driver.T4C8Oall.receive(T4C8Oall.java:745)

I think that the 'error' that ending up being reported as the failure, is failing to take a screen-snapshot on the failed test, because I see this in the test log:

2015-04-01 10:02:34,430 [ERROR] EvaLevel2WithLimitAmountsTest@9 > CorporateTestData@304 > sql
Error number 1
com.thoughtworks.selenium.SeleniumException: org.openqa.grid.common.exception.GridException: Session [d6c716c23a8044a1b3f99bf6225ec2f8] was terminated due to ORPHAN
at com.thoughtworks.selenium.HttpCommandProcessor.throwAssertionFailureExceptionOrError(HttpCommandProcessor.java:109)
at com.thoughtworks.selenium.HttpCommandProcessor.getCommandResponseAsString(HttpCommandProcessor.java:180)
at com.thoughtworks.selenium.HttpCommandProcessor.executeCommandOnServlet(HttpCommandProcessor.java:115)
at com.thoughtworks.selenium.HttpCommandProcessor.doCommand(HttpCommandProcessor.java:98)
at com.thoughtworks.selenium.HttpCommandProcessor.getString(HttpCommandProcessor.java:272)
at com.thoughtworks.selenium.DefaultSelenium.captureEntirePageScreenshotToString(DefaultSelenium.java:767)
at org.paxml.selenium.rc.XSelenium.takeSnapshot(XSelenium.java:353)
at org.paxml.selenium.rc.SeleniumTag$PaxmlListener.checkToClose(SeleniumTag.java:121)
at org.paxml.selenium.rc.SeleniumTag$PaxmlListener.onExit(SeleniumTag.java:150)
at org.paxml.launch.Paxml.callEntityExitListener(Paxml.java:235)
at org.paxml.launch.Paxml.execute(Paxml.java:212)
at org.paxml.launch.Paxml.execute(Paxml.java:161)
at org.paxml.launch.Paxml.execute(Paxml.java:130)
at org.paxml.launch.LaunchModel.execute(LaunchModel.java:156)
at org.paxml.launch.LaunchPoint.execute(LaunchPoint.java:121)
at org.paxml.testng.PaxmlTestCase.doTest(PaxmlTestCase.java:119)
at org.paxml.testng.AbstractPaxmlTestResult.executeTest(AbstractPaxmlTestResult.java:137)
at sun.reflect.GeneratedMethodAccessor268.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.testng.internal.MethodHelper.invokeMethod(MethodHelper.java:609)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:532)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:686)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1018)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:128)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
at org.testng.internal.thread.ThreadUtil$CountDownLatchedRunnable.run(ThreadUtil.java:141)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)

I feel that failures in the 'onExit' should be reported in the log, but should not cause the test to fail. The error that occurs during the onExit should definitely not be reported as the failure cause.

By the way, the testcase that is failing here has not opened a Selenium session yet (at the point of failure it has defined test data and is attempting to insert into the database,) still paxml attempts to terminate the session and to take a screen/snapshot. Maybe the solution can be as simple as to check whether a session is there before attempting the snapshot?

[niuxuetao]

fixed in r1.8