Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.2 alt:radar returns altitude when "too high" #283

Closed
JoCRaM opened this issue Dec 3, 2013 · 7 comments
Closed

v0.9.2 alt:radar returns altitude when "too high" #283

JoCRaM opened this issue Dec 3, 2013 · 7 comments

Comments

@JoCRaM
Copy link

JoCRaM commented Dec 3, 2013

behavior introduced in 45f94cf

should at least be documented. t

@JoCRaM JoCRaM closed this as completed Dec 3, 2013
@JoCRaM JoCRaM reopened this Dec 3, 2013
@Dunbaratu
Copy link
Contributor

I too preferred the old behavior. At least with returning an invalid number like -1, you were aware that the radar altitude was lying to you and you knew not to rely on it. Right now you can't tell the difference between "alt:radar and altitude are the same number because I'm too high" versus "alt:radar and altitude are the same number because the terrain I'm over is at sea level."

@JoCRaM
Copy link
Author

JoCRaM commented Dec 3, 2013

they're not even at the same level, because your ship has moved.

wasted a good bit of time tying to work out why my lander wasn't 1000 metres above the ground at periapsis...

@weissel
Copy link

weissel commented Dec 4, 2013

@BiZZKeryear You might want an alt:radar:raw. Have fun dealing with -1 and alt:radar > altitude (over water).
I don't fancy spending my limited cycle budget on these ...

@JoCRaM
Copy link
Author

JoCRaM commented Dec 5, 2013

"None" would seem to follow the conventions used elsewhere, but if for some bizarre reason we want this to lie then I'd say "max_radar_alt" would be the best value. but it should report the sea-bed, just like the dial does in the cockpit view - how else can you aim for a splashdown?

@weissel
Copy link

weissel commented Dec 6, 2013

Aiming for a splashdown? Use the geocoordinates of the place you want to reach, not the fact that you are right now over water ... unless you restrict yourself to coming to a full stop (in regard to the surface) right here where your radar readings imply there is liquid below you.

@JoCRaM
Copy link
Author

JoCRaM commented Dec 6, 2013

Where in the user interface are geocoordinates shown? regardless, the KSP I'm playing limits me to information that doesn't require omniscience.

My strattegy was to have been if I've been over 50m of water for "long enough" then to aim for this spot on the next orbit. My new strategy is indeed to kill surface speed once I'm over deep enough water.

@JoCRaM JoCRaM closed this as completed Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Dunbaratu @weissel @JoCRaM and others