Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] nivturk plugins sometimes fail to load #105

Closed
szorowi1 opened this issue Dec 5, 2022 · 0 comments · Fixed by #106 or #107
Closed

[bug] nivturk plugins sometimes fail to load #105

szorowi1 opened this issue Dec 5, 2022 · 0 comments · Fixed by #106 or #107
Assignees
@szorowi1
Labels
bug Something isn't working

Comments

@szorowi1
Copy link
Contributor

szorowi1 commented Dec 5, 2022 •
edited
Loading

During data collection, an online participant reported to @seanmallan that they experienced a technical issue upon completing an experiment. Specifically, the participant was redirected to a blank screen. The participant looked for an error message and found Uncaught ReferenceError: redirect_success is not defined. In other words, the nivturk-plugins silently failed to load!

As a stopgap, @szorowi1 hard-coded the nivturk plugins into the experiment.html file. That is, @szorowi1 made it such that the redirect functions could never fail to be loaded. Afterwards, far fewer participants sent @seanmallan complaints.

This suggests one of two changes should be made:

  1. The redirect functions in nivturk-plugins.js should be hardcoded into experiment.html.
  2. The experiment cannot proceed until nivturk-plugins.js is successfully loaded.

@szorowi1 will look into the viability of (2), otherwise will proceed with (1).
@szorowi1 szorowi1 self-assigned this Dec 5, 2022
@szorowi1 szorowi1 added the bug Something isn't working label Dec 5, 2022
szorowi1 added a commit that referenced this issue Dec 5, 2022
@szorowi1
prolific-issue-#105
314cb42 
- to address issue #105
- move nivturk plugins to experiment.html
- delete nivturk-plugins.js
szorowi1 added a commit that referenced this issue Dec 5, 2022
@szorowi1
mturk-issue-#105
af0b4fc 
- to address issue #105
- move nivturk plugins to experiment.html
- delete nivturk-plugins.js
@szorowi1 szorowi1 mentioned this issue Dec 5, 2022
Merged
@szorowi1 szorowi1 linked a pull request Dec 5, 2022 that will close this issue
prolific-issue-#105 #106
Merged
@szorowi1 szorowi1 mentioned this issue Dec 5, 2022
Merged
@szorowi1 szorowi1 linked a pull request Dec 5, 2022 that will close this issue
mturk-issue-#105 #107
Merged
szorowi1 added a commit that referenced this issue Dec 6, 2022
@szorowi1
prolific-issue-#105 (#106)
e9ce8bc 
- to address issue #105
- move nivturk plugins to experiment.html
- delete nivturk-plugins.js
szorowi1 added a commit that referenced this issue Dec 6, 2022
@szorowi1
mturk-issue-#105 (#107)
39d743d 
- to address issue #105
- move nivturk plugins to experiment.html
- delete nivturk-plugins.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szorowi1 szorowi1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prolific-issue-#105 nivlab/nivturk
mturk-issue-#105 nivlab/nivturk
1 participant
@szorowi1