Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added French localization #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added French localization #57

wants to merge 4 commits into from

Conversation

Yann-R
Copy link

@Yann-R Yann-R commented Nov 10, 2021

Added in Resources one new folder fr.lproj containing Localizable.strings UTF-8 file translated into French.

@niw
Copy link
Owner

niw commented Nov 11, 2021

Hi, @Yann-R, To make translation works, could you add this new locale in the Xcode project also use UTF-16 encoding for Localizable.strings instead so that it can actually work.

@Yann-R
Copy link
Author

Yann-R commented Nov 12, 2021

Hi @niw

  • OK, I'll do... I can switch UTF-8 to UTF-16... But currently your software was working on my system with this new localization in UTF-8 without any problem... And it seems that github was considering this file as 'BIN' for the commit... I'll convert it to UTF-16 as soon as possible.

  • For adding this "new locale in the Xcode project", can you tell me more? I observed 3 editions in project.pbxproj when a new language is added to github source, but where do the ID come from, e.g. this for Korean: 86CF8F652615CBFA00BBE416 /* ko */

Best regards.

Converted French Localizable.strings from UTF-8 to UTF-16 (as other languages).
@niw
Copy link
Owner

niw commented Nov 13, 2021

@Yann-R Please follow next steps after opening HapticKey.xcodeproj by the latest Xcode.

Open HapticKey project file then, select HapticKey under Project, then in Localization, click plus button then select "French (fr)".
1

Uncheck MainMenu.xib then click "Finish".
2

Select HapticKey/Resources/Localizable.strings/Localizable.strings (French) and edit the file.
3

Then commit HapticKey.xcodeproj/project.pbxproj and HapticKey/Resources/fr.lproj/Localizable.strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants