add None value for cache extension #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Mar 11, 2021
|
It looks like this change is much like the one in django 2.0 from four years ago, that allowed a None timeout:
So this gets approval from me. I contributed a test and added a line in the changelog. |
auvipy
approved these changes
Mar 14, 2021
|
hmm, i thought that doing it that way would have merged [and closed] this PR as well, but maybe it didn't because the merge was done with a rebase. @auvipy could you merge or close this? |
|
the commit is merged |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Django docs said The fragment is cached forever if timeout is None. However when I set timeout to None get this error:
"cache" tag got a non-integer timeout value: None. So I made a little fix.