feat: use internal WSL knobs instead of symlinks #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed an issue with upstream to maybe stabilize these: microsoft/WSL#10425 |
This makes things so much easier and more consistent and it's undocumented API that I found in Ghidra so nothing could possibly go wrong.
|
This looks so much better. I hope they decide to keep these |
| @@ -41,6 +41,21 @@ with lib; { | |||
| default = false; | |||
| description = "Use systemd as init. There's no need to enable this manually, use the wsl.nativeSystemd option instead"; | |||
| }; | |||
| initPath = mkOption { | |||
| type = path; | |||
There was a problem hiding this comment.
Doesn't this need to be nullOr path?
There was a problem hiding this comment.
Probably, I haven't actually tested this on non-native-systemd yet.
| systemd = true; | ||
| initPath = "${nativeUtils}/bin/systemd-shim"; | ||
| initShutdownCommand = pkgs.writeShellScript "nixos-wsl-init-shutdown" '' | ||
| ${pkgs.systemd}/bin/systemctl reboot |
There was a problem hiding this comment.
Suggested change
| ${pkgs.systemd}/bin/systemctl reboot | |
| ${pkgs.systemd}/bin/systemctl reboot "$@" |
just incase
There was a problem hiding this comment.
I'm actually pretty sure we can avoid the shell script here and just write the string directly.
|
This is drifting out of sync and I don't want to maintain it until upstream decides this is OK to do. Closing for now, we can revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things so much easier and more consistent and it's undocumented API that I found in Ghidra so nothing could possibly go wrong.