Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul learning section and add a bunch of things #172

Closed
wants to merge 5 commits into from

Conversation

alper
Copy link
Contributor

@alper alper commented May 20, 2023

This is really good and covers a lot. Should probably be most people's introduction to Nix. Not the current number one there.

alper added 3 commits May 20, 2023 20:50
This is really good and covers a lot. Should probably be most people's introduction to Nix. Not the current number one there.
Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this below the "How to Learn" entry to maintain alphabetical ordering. Otherwise looks good

@alper
Copy link
Contributor Author

alper commented May 21, 2023

That How to Learn Nix series of articles is pretty outdated. Not sure if that makes sense.

Let me make a bigger change with in what direction I'm thinking of here.

@alper
Copy link
Contributor Author

alper commented May 21, 2023

Here:

  • Split out Nix language and NixOS as separate learning topics
  • Added Zero to Nix which should probably be most people's starting point
  • Pulled up nix.dev
  • Updated link to Nix Shorts which I've forked and updated (old repo is dead)
  • Added the multi-part Rust/Nix series by Amos which is really very good
  • Added the nix.dev page on Nix language to the language section

@alper alper changed the title Add Tony Finn's introduction to Nix Overhaul learning section and add a bunch of things May 23, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/good-non-official-nix-resources/28400/3

Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay -- again, looking to maintain alphabetical ordering.

Breaking out sections doesn't make sense as well when there are only one or two items to even put in the section.

Also, that's 4 new entries. I'm not against reviewing them, but you've made this difficult by putting them all in the same PR, alongside a bunch of formatting and ordering changes, instead of letting each one stand on its own. Nor does it seem appropriate to have multiple copies of the same resource (nix.dev) in this list.

Please either present individual suggestions for the items, or consider just reorganization within a single PR, like I did in #158

@alper
Copy link
Contributor Author

alper commented May 29, 2023

or consider just reorganization within a single PR

I don't understand. Wouldn't this be the reorganization within a single PR?

Breaking out sections doesn't make sense as well when there are only one or two items to even put in the section.

I think more items would be found for the other sections but I think it makes sense to break these out because they're distinctly different things. A person interested in nixpkgs does not necessarily have to be interested in NixOS.

Also we can maintain alphabetical order but it would mean highly outdated things coming before newer resources.

But OK. Let me know if this can go as a single PR and otherwise I'll break this up in single suggestions.

@cyntheticfox
Copy link
Member

Yes, this is within a single PR. It isn't just reorganization though, it's a bunch of additions and moves as well.

If these older items are outright incorrect now, we can move them to the DEPRECATED.md file to reflect that. Otherwise, I keep them alphabetical in line with CONTRIBUTING.md, and formatted like https://github.com/sindresorhus/awesome/blob/main/awesome.md#make-it-clear-what-the-list-is-about, as this isn't an ordered list -- it's a curated list of awesome projects. A more comprehensive list, and one that provides a suggested ordering, would be more appropriate for something like the Wiki. I do agree NixOS isn't the same as the Nix language and other projects, which is why I advocated for breaking them into their own section in #158, but perhaps NixOS has gotten large enough to warrant its own awesome page

@alper
Copy link
Contributor Author

alper commented May 31, 2023

I do agree NixOS isn't the same as the Nix language and other projects

I'd prefer to never see anything about NixOS but in most places it is the dominant thing that most conversations and questions are about.

@alper
Copy link
Contributor Author

alper commented May 31, 2023

Yes, this is within a single PR. It isn't just reorganization though, it's a bunch of additions and moves as well.

OK. I'm closing this and I made a bunch of PRs with single additions in each all of which should still be alphabetical.

@alper alper closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants