Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-tools: add nix-alien #94

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Conversation

thiagokokada
Copy link
Contributor

This is a new project of mine, a Python script inspired by https://github.com/Lassulus/nix-autobahn that easily allows running unpatched binaries on Nix/NixOS.

@cyntheticfox
Copy link
Member

Looks like the automatic link checker hasn't been working. Let me fix that failing URL.

@cyntheticfox
Copy link
Member

This looks like a useful project, but it feels too young. This is like the fourth time I've seen this happen with the repository, so I opened #96. Depending on how that goes or if 30 days pass and this is being maintained/used, I think it's good to approve

@thiagokokada
Copy link
Contributor Author

This looks like a useful project, but it feels too young. This is like the fourth time I've seen this happen with the repository, so I opened #96. Depending on how that goes or if 30 days pass and this is being maintained/used, I think it's good to approve

Yeah, I think it is fair. Not that I expect it to have too many changes unless I find a bug or something.

Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, kinda forgot to check back. Double-checking, the project is still good, but it looks like I missed something the first time I looked: could you move nix-alien above nix-diff to maintain the alphabetical ordering?

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Dec 29, 2021

Okay, kinda forgot to check back. Double-checking, the project is still good, but it looks like I missed something the first time I looked: could you move nix-alien above nix-diff to maintain the alphabetical ordering?

Done.

Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@cyntheticfox cyntheticfox merged commit 4b7092b into nix-community:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants