Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using mk functions #43

Closed
rycee opened this issue Aug 12, 2021 · 3 comments · Fixed by #44
Closed

Using mk functions #43

rycee opened this issue Aug 12, 2021 · 3 comments · Fixed by #44

Comments

@rycee
Copy link
Member

rycee commented Aug 12, 2021

I noticed in nix-community/home-manager#2249 that dconf2nix generates output in a "raw" dconf format, for example, the uint32 value 0 is emitted as a Nix string "uint32 0". This is not really the intended way to construct GVariant values in the HM library. The recommended way to emit values is to use the various mk functions as described in the manual (scroll down to where hm.types.gvariant starts).

For example, instead of having "uint32 0" one would use lib.hm.gvariant.mkUint32 0. Using the functions should be considerably more robust.

Btw, very neat project! Good job 🙂

@rycee
Copy link
Member Author

rycee commented Aug 12, 2021

Btw, you can see the functions in action in the gvariant test case.

@gvolpe
Copy link
Collaborator

gvolpe commented Aug 13, 2021

Thanks a lot @rycee ! Didn't know about those mk functions, will get it done soon :)

@parthy
Copy link

parthy commented Aug 14, 2021

Thanks to both of you for taking care of this! It works perfectly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants