lib: refactor actually a lot of stuff (sorry mic) #294
Conversation
Lassulus
force-pushed
the
refactor3
branch
11 times, most recently
from
4de3fa5
to
04e7af6
Compare
Lassulus
changed the title
Lassulus
changed the title
|
not sure if the cli is still working, since we have no tests for it :( EDIT: I remembered how to use the cli and it is broken :(( EDIT2: yay I fixed it again :) |
| @@ -85,7 +85,7 @@ A simple disko configuration may look like this: | |||
| If you'd saved this configuration in /tmp/disko-config.nix, and wanted to create a disk named /dev/nvme0n1, you would run the following command to partition, format and mount the disk. | |||
|
|
|||
| ``` | |||
| $ sudo nix run github:nix-community/disko -- --mode zap_create_mount /tmp/disko-config.nix --arg disks '[ "/dev/nvme0n1" ]' | |||
| $ sudo nix run github:nix-community/disko -- --mode disko /tmp/disko-config.nix --arg disks '[ "/dev/nvme0n1" ]' | |||
There was a problem hiding this comment.
Do we have some documentation what each of these modes do?
It's not exactly intuitive from the name.
There was a problem hiding this comment.
added some documentation to the help output of the disko cli
| mountScript = cfg: pkgs: ((eval cfg).config.disko.devices._scripts { inherit pkgs checked; }).mountScript; | ||
| mountScriptNoDeps = cfg: pkgs: ((eval cfg).config.disko.devices._scripts { inherit pkgs checked; }).mountScriptNoDeps; | ||
|
|
||
| disko = cfg: (eval cfg).config.disko.devices._disko; |
There was a problem hiding this comment.
So disko is the new umount+format+mount?
There was a problem hiding this comment.
create is an alias for format. disko is umount + format + mount
There was a problem hiding this comment.
As I just learned it's umount + destroy + format + mount
There was a problem hiding this comment.
umount and destroy are the same thing right now
not really. But I'm not sure if type = "gpt" breaks in some scenarios |
|
added a legacy table test, renamed _umount to _destroy. |
…emConfig & extraInstallerConfig
|
ah forget the test, I also included some other stale PRs which I took a look at |
|
|
I cannot find this commit. |
|
Basically what #78 does |
|
ok dropped the commit for now, we need better migrations for that one |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 774ce7d |
No description provided.