tests: Add failing test to demonstrate issues with whitespace in part… #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… names Reproduces nix-community#130. For new style table the generated script has a few problems for example; ```sh sgdisk \ --new=2:0:+100M \ --change-name=2:disk-vdb-name with spaces \ --typecode=2:EF00 \ /dev/vdb ``` and ```sh mkfs.vfat \ \ /dev/disk/by-partlabel/disk-vdb-name with spaces ``` Legacy table style generates slightly different problems e.g.; ```sh parted -s /dev/vdb -- mkpart name with spaces 1MiB 100MiB ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… names
Reproduces #130.
For new style table the generated script has a few problems for example;
sgdisk \ --new=2:0:+100M \ --change-name=2:disk-vdb-name with spaces \ --typecode=2:EF00 \ /dev/vdband
mkfs.vfat \ \ /dev/disk/by-partlabel/disk-vdb-name with spacesLegacy table style generates slightly different problems e.g.;