bcachefs: add support for subvolumes #499
Conversation
|
do we want to extend this also for multidisks? if yes then we need to split the bcachefs type into a type which marks the disk for including it in a bcachefs array and another toplevel type to assemble the array. The toplevel type would be mostly the same as the bcachefs type here, but with support for multiple disks. |
|
I think even if we don't implement this feature fully just now, we should already prepare it in this direction. Otherwise we need to break compatibility with people soon again. |
|
The docs provide a complex example of how one formats a multi-disk filesystem, https://bcachefs-docs.readthedocs.io/en/latest/mgmt-formatting.html . Based on that, I would probably suggest we create our own construct, a multi-disk toplevel type named something like In that case, I'm failing to see how what is done here would break compatibility for a separate type. Thoughts? |
adamcstephens
force-pushed
the
bcachefs
branch
from
d1342e4
to
03baa84
Compare
| name = "root"; | ||
| end = "-0"; | ||
| content = { | ||
| type = "bcachefs"; |
There was a problem hiding this comment.
If we have two types, than we should rename this one to bcachefs_single or similar. Otherwise it creates confusion when people try to use bcachefs for multi disk setups.
There was a problem hiding this comment.
Looks mostly good.
I agree that we should start separating between single- and multi-disk bcachefs types with this PR, even if it doesn't implement the functionality.
Also I'm not sure, but is there an assertion that allows us to check whether the user has defined a bcachefs enabled kernel (i.e. by comparing versions, even if inputs.nixpkgs is overwritten)?
I think that would be better than just overwriting whatever the user defines.
| nixpkgs.overlays = [ | ||
| (_final: super: { zfs = super.zfs.overrideAttrs (_: { meta.platforms = [ ]; }); }) | ||
| ]; | ||
| boot.kernelPackages = pkgs.lib.mkForce pkgs.linuxPackages_testing; |
There was a problem hiding this comment.
This can be changed to pkgs.linuxPackages_latest - testing is no longer required on unstable
| nixpkgs.overlays = [ | ||
| (_final: super: { zfs = super.zfs.overrideAttrs (_: { meta.platforms = [ ]; }); }) | ||
| ]; | ||
| boot.kernelPackages = pkgs.lib.mkForce pkgs.linuxPackages_testing; |
There was a problem hiding this comment.
This can be changed to pkgs.linuxPackages_latest - testing is no longer required on unstable
|
Would this PR enable declarative configuration of a single bcachefs filesystem spanning:
I could help test it if so. |
No, that would be different effort to extend multi disk support. I’m actually going to close this as I won’t be finishing it any time soon. Someone else should feel free to pick it up. |
|
We probably need a generic solution for mutli device support which integrates nicely with the single disk usecase. |
Picked up the work started by Raito. 6.7 was just released, but isn't in unstable yet.
Closes: #449