types table: add deprecation warning

[Lassulus]

No description provided.

[Lassulus]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[nifoc]

Is there some kind of documentation/explanation of how to move from table to gpt?

I just got this error but it's very unclear to me how I should deal with it.

To expand on this: I import this file in my flake-based configuration, so every rebuild now triggers:

trace: warning: The legacy table is outdated and should not be used. We recommend using the gpt type instead.
Please note that certain features, such as the test framework, may not function properly with the legacy table type.
If you encounter errors similar to:
"error: The option `disko.devices.disk.disk1.content.partitions."[definition 1-entry 1]".content._config` is read-only, but it's set multiple times,"
this is likely due to the use of the legacy table type.

trace: warning: The legacy table is outdated and should not be used. We recommend using the gpt type instead.
Please note that certain features, such as the test framework, may not function properly with the legacy table type.
If you encounter errors similar to:
"error: The option `disko.devices.disk.disk1.content.partitions."[definition 1-entry 1]".content._config` is read-only, but it's set multiple times,"
this is likely due to the use of the legacy table type.

trace: warning: The legacy table is outdated and should not be used. We recommend using the gpt type instead.
Please note that certain features, such as the test framework, may not function properly with the legacy table type.
If you encounter errors similar to:
"error: The option `disko.devices.disk.disk1.content.partitions."[definition 1-entry 1]".content._config` is read-only, but it's set multiple times,"
this is likely due to the use of the legacy table type.

trace: warning: The legacy table is outdated and should not be used. We recommend using the gpt type instead.
Please note that certain features, such as the test framework, may not function properly with the legacy table type.
If you encounter errors similar to:
"error: The option `disko.devices.disk.disk1.content.partitions."[definition 1-entry 1]".content._config` is read-only, but it's set multiple times,"
this is likely due to the use of the legacy table type.

Looking through the code, it seems like table and gpt are pretty different and you can't "just move" an existing installation/setup.

[Lassulus]

Ah there pretty sure is. But I have not done it myself yet. If you don't want to reformat, it should be fairly straight forward and I will try to write something up in the next week. Sorry for the noise of the warning until then

[kira-bruneau]

Is table only deprecated for gpt partition tables? This warning still comes up if you're using mbr/msdos, but I can't find any other alternative.

[Lassulus]

Yeah. Maybe hybrid gpt partitions can be used in that case. But I would declare legacy/msdos tables in general deprecated? What is your usecase for them?

[kira-bruneau]

Mainly just using it as a declarative configuration for mounting an already formatted drive.

I tried using the gpt type, but msdos doesn't support partition labels, so right now it fails when trying to mount through /dev/disk/by-partlabel.

I could also just use the nixos filesystem module directly, but I've been trying to keep all disk-specific configuration in disko.

[Lassulus]

hmm I guess in that case you can ignore the warning, or we could move it to the create argument, but then people only see it when creating new drives and there it could be already to late.