Use existing bash instance when running destroyScript #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, not sure how portable that is. but it works in the tests, so let's hope it doesn't break anyones usecase |
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
Mic92
reviewed
Apr 6, 2024
| @@ -449,7 +449,7 @@ let | |||
|
|
|||
| # shellcheck disable=SC2043 | |||
| for dev in ${toString (lib.catAttrs "device" (lib.attrValues devices.disk))}; do | |||
| ${../disk-deactivate}/disk-deactivate "$dev" | |||
| $BASH ${../disk-deactivate}/disk-deactivate "$dev" | |||
There was a problem hiding this comment.
Do we need this?
Suggested change
| $BASH ${../disk-deactivate}/disk-deactivate "$dev" | |
| ${BASH:-} ${../disk-deactivate}/disk-deactivate "$dev" |
jmbaur
force-pushed
the
jbaur/shell-self-contained
branch
from
69821f5
to
e3448ff
Compare
|
@mergify rebase |
The destroy script already has a bash interpreter in use, but when the `disk-deactivate` script is ran, it calls out to /usr/bin/env to query for a bash interpreter. When running the destroyScript in unique places (such as the stage-1 initrd), /usr/bin/env might not exist, so we can make destroyScript more self-contained by reusing the same bash.
✅ Branch has been successfully rebased |
Lassulus
force-pushed
the
jbaur/shell-self-contained
branch
from
e3448ff
to
82783db
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8d4ae69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destroy script already has a bash interpreter in use, but when the
disk-deactivatescript is ran, it calls out to /usr/bin/env to query for a bash interpreter. When running the destroyScript in unique places (such as the stage-1 initrd), /usr/bin/env might not exist, so we can make destroyScript more self-contained by reusing the same bash.