Track option types more accurately #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirelagin
force-pushed
the
string-length
branch
2 times, most recently
from
876f4f9
to
53ae0a7
Compare
Turns out, strings in DNS zones have size limitations. In particular, domain names cannot be longer than 255 octets. Some other strings, such as data in TXT records, are not limited in length, but the STRING LITERALS used in zone files are limited to 255 octets. * Annotate each record file with a reference to the corresponding RFC. * Add a new option type (lib.dns.types.domain-name), which is a string limited to 255 characters. * Use the new `domain-name` type instead of `str` where appropriate. * Add a helper util that breaks a string of aribtrary length into multiple string literals, each no longer than 255 characters. * Use the new helper where appropriate (I hope).
|
Thanks, it works perfectly! |
Show the type correctly (it had a wrong why from an earlier versions) and explain more clearly what the function actually does, in particular that it qutoes the string, so one doesn’t need to do it manually.
|
Great! Thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
@em0lar, does this work for your use case?