Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack overflow with a certain Rust project #86

Closed
yusdacra opened this issue Feb 16, 2022 · 1 comment · Fixed by #88
Closed

stack overflow with a certain Rust project #86

yusdacra opened this issue Feb 16, 2022 · 1 comment · Fixed by #88

Comments

@yusdacra
Copy link
Member

It seems the Rust builder will stack overflow if used on the helix repo. I've tested the translator separately, which works fine. This also happens on #83 with the crane builder, so it doesn't seem to be specific to the buildRustPackage builder.

repro:

{
  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
    dream2nix = {
      url = "github:nix-community/dream2nix";
      inputs.nixpkgs.follows = "nixpkgs";
    };
    helix = {
      url = "github:helix-editor/helix";
      flake = false;
    };
  };

  outputs = inputs@{ nixpkgs, dream2nix, helix, ... }:
    let
      system = "x86_64-linux";
      dream2nix = inputs.dream2nix.lib.init {
        pkgs = nixpkgs.legacyPackages.${system};
      };
    in dream2nix.riseAndShine { source = helix; };
}
@yusdacra
Copy link
Member Author

Fixed this on #83. The issue was that the code that got all transitive dependencies were handling cyclic dependencies incorrectly, which caused it to recurse infinitely. I'll keep this open until #83 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant