pip: disable cache for modified response #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to impose a significant performance bottleneck. With large closures re-fetching everything all over again on each lock update is quite expensive considering that some python packages are several 100MB in size. While I'm aware that fixing the bug is more important than performance, I wonder if there are alternatives. Could we just remove the versions from the response as well and fix the inconsitency thereby? |
The pypi proxy filters packages, which can end up corrupting the pip cache. For an example of what this would look like, see pypi/warehouse#14457 This commit prevents the the cache from storing our modified response by adding a 'Vary: *' header. Judging from the caching code, this is the least intrusive approach to prevent caching ('Cache-Control: no-cache' deletes existing caches for example).
VincentVanlaer
force-pushed
the
pip-no-cache
branch
from
7ddf77c
to
83403f7
Compare
VincentVanlaer
changed the title
|
Did some digging in the pip source code, found a way to disable the cache only on the modified responses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pypi proxy filters packages, which can end up corrupting the pip cache. For an example of what this would look like, see pypi/warehouse#14457