New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/state snapshot #93
Conversation
brianmcgee
commented
Feb 2, 2023
•
edited
edited
- feat(modules): better organise modules
- feat(modules): namespace services under ethereum. where type is consensus or execution
- feat(modules/snapshot): basic control of service state volume
- feat(modules): replace foldListToAttrs lib function with mkMerge
- feat(modules): basic volume setup and snapshotting
- feat(modules/snapshot): add ISO 8601 timestamp to snapshots
- feat(modules/snapshot): add restart interval for periodic snapshotting
- feat(modules): refine namespacing changes, removing the consensus and execution part of the key
- feat(modules/snapshot): update the README
… consensus or execution
… execution part of the key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
From my point of view, I think we should start creating releases in ethereum.nix
to incorporate the fact we may break things.
That way we can avoid having our consumers discover with our latest change we're breaking them their config (as we are still iterating and stabilizing how we would like to define our modules and snapshots and whatnot).
I'll add an issue to track this specific fact.
Otherwise LGTM.
I agree. There are also strategies for renaming options which we can start following, but given we are still in the early days I'd like to keep breaking things as necessary is in the short term. |