Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] make fenix work with nix flake check #87

Merged
merged 2 commits into from
Nov 14, 2022
Merged

[RFC] make fenix work with nix flake check #87

merged 2 commits into from
Nov 14, 2022

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Oct 26, 2022

fixes #60

also renames fenix.overlay to fenix.overlays.default as per NixOS/nix#5532
If I did it correctly, this shouldn't be a breaking change, but there is a drawback that nix build .#stable now shows error: attribute 'packages.x86_64-linux.stable.drvPath' does not exist which might be confusing to the user

before:

$ nix flake check
error: flake attribute 'packages.x86_64-linux.default' is not a derivation
(use '--show-trace' to show detailed location information)

$ nix flake show
github:nix-community/fenix/0748dc3f419917e3548419e91839ee062e1a88fb
├───overlay: Nixpkgs overlay
└───packages
    ├───aarch64-darwin
error: expected a derivation

after:

$ nix flake check
trace: warning: `fenix.overlay` is deprecated; use 'fenix.overlays.default' instead
warning: flake output attribute 'overlay' is deprecated; use 'overlays.default' instead

$ nix flake show
github:nix-community/fenix/7d280610237379462e5f2fce7993b17cff53d730
├───overlay: Nixpkgs overlay
├───overlays
│   └───default: Nixpkgs overlay
└───packages
    ├───aarch64-darwin
    │   ├───beta: package 'dummy-attrset'
    │   ├───combine: package 'dummy-lambda'
    │   ├───complete: package 'dummy-attrset'
    │   ├───default: package 'dummy-attrset'
    │   ├───fromManifest: package 'dummy-lambda'
    │   ├───fromManifestFile: package 'dummy-lambda'
    │   ├───fromToolchainFile: package 'dummy-lambda'
    │   ├───latest: package 'dummy-attrset'
    │   ├───minimal: package 'dummy-attrset'
    │   ├───rust-analyzer: package 'rust-analyzer-nightly-53b6d69'
    │   ├───rust-analyzer-vscode-extension: package 'vscode-extension-rust-analyzer-53b6d69'
    │   ├───stable: package 'dummy-attrset'
    │   ├───targets: package 'dummy-attrset'
    │   └───toolchainOf: package 'dummy-lambda'
    ├───aarch64-linux
    [...]

@figsoda figsoda mentioned this pull request Oct 26, 2022
Open
@figsoda figsoda changed the base branch from main to staging October 26, 2022 21:46
@figsoda
Copy link
Member Author

figsoda commented Nov 5, 2022

@zimbatm any comments/suggestions?

@figsoda figsoda merged commit 57049c8 into staging Nov 14, 2022
@figsoda figsoda deleted the flake-check branch November 14, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packages output supposed to only contain derivations
1 participant
@figsoda