Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support passing extra build flags #104

Open
yihuang opened this issue Feb 7, 2023 · 1 comment · May be fixed by #115
Open

support passing extra build flags #104

yihuang opened this issue Feb 7, 2023 · 1 comment · May be fixed by #115

Comments

@yihuang
Copy link
Contributor

yihuang commented Feb 7, 2023 •
edited

go 1.20 support a new build flag -cover which we'd like to use for integration test, currently the only way to pass that is through buildFlags parameter, but it trigger a warning.
I suggest we either remove the warning or support new method to customize build flags.
@yihuang yihuang mentioned this issue Feb 7, 2023
Merged
13 tasks
@eliasnaur
Copy link

eliasnaur commented Mar 14, 2023 •
edited

I have a similar problem, but with -buildmode pie, which is required for building with the Musl standard library.

eliasnaur pushed a commit to eliasnaur/gomod2nix that referenced this issue Mar 30, 2023
@seedhammer
Silence warning when buildFlags are set
7598e3f 
The warning was to avoid misuse of buildFlags for specifying Go build
tags, but there are other legitimate uses such as `-buildmode`, `-cover`.

Fixes nix-community#104
@eliasnaur eliasnaur mentioned this issue Mar 30, 2023
Closed
eliasnaur added a commit to eliasnaur/gomod2nix that referenced this issue Mar 30, 2023
@eliasnaur
Silence warning when buildFlags are set
e16a58b 
The warning was to avoid misuse of buildFlags for specifying Go build
tags, but there are other legitimate uses such as `-buildmode`, `-cover`.

Fixes nix-community#104
@eliasnaur eliasnaur linked a pull request Mar 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yihuang @eliasnaur