New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Merge nixos-module-user-pkgs #549
Comments
I recall some issue with Qt applications, and I mention this in #97 (comment) but I can't remember exactly what the issue was. I would very much like to merge this branch, nobody likes having it around for so long and rebasing it regularly. I don't use it myself, though and simply don't have the time to thoroughly use it to be confident it won't break too many things. It might be possible to change the behavior such that it will use |
@rycee can we merge it down gated by a boolean flag disabled by default? |
@kalbasit Yeah, that's sort of what I meant by restricting it to state version 19.03 or later. So for people having the state version set to 18.09 it would keep installing to |
@rycee Let's do that then, I would love to try it out on my daily driver as opposed to dedicate time for testing it. |
I've started working on this and it should be quite doable. I could give you a deadline for when it's ready but then I'd also have to tell you that I most likely would break the deadline 😉 |
See #580 for a PR that supports both
to your NixOS configuration to enable installation into |
@rycee you're awesome, thank you! I'll try it on the way to work tomorrow! |
I just went ahead and deployed this on my productive system. Seems to work for me. I am just a bit curious, why we need the boolean flag. Does anyone have the I am not against that option it makes sense to have it. With it it would it even be possible to merge this into nixpkgs. But I don't understand why not having this option would break anyone's setup when merging into master. It is my understanding that the features in this branch shouldn't affect users installing via |
@kalbasit Glad you like it, hope it works well for you! @maralorn Good to head that it worked! I wanted the boolean flag because I don't entirely trust the |
In master now 😀 |
I would be interested in what is missing to merge the nixos-module-user-pkgs into master. I don't see any technical reason.
It does not feel so nice to lag a bit behind master and sometimes following a constantly rebased branched is quite inconvenient. (e.g. when you want to try an earlier version).
The text was updated successfully, but these errors were encountered: