Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Merge nixos-module-user-pkgs #549

Closed
maralorn opened this issue Jan 24, 2019 · 10 comments
Closed

Feature request: Merge nixos-module-user-pkgs #549

maralorn opened this issue Jan 24, 2019 · 10 comments

Comments

@maralorn
Copy link
Contributor

I would be interested in what is missing to merge the nixos-module-user-pkgs into master. I don't see any technical reason.
It does not feel so nice to lag a bit behind master and sometimes following a constantly rebased branched is quite inconvenient. (e.g. when you want to try an earlier version).

@rycee
Copy link
Member

rycee commented Jan 24, 2019

I recall some issue with Qt applications, and I mention this in #97 (comment) but I can't remember exactly what the issue was.

I would very much like to merge this branch, nobody likes having it around for so long and rebasing it regularly. I don't use it myself, though and simply don't have the time to thoroughly use it to be confident it won't break too many things.

It might be possible to change the behavior such that it will use users.users.<name?>.packages only if you have HM state version 19.03 or later. That is probably a more robust way forward since it would allow people to try it out without too much risk.

@kalbasit
Copy link
Collaborator

@rycee can we merge it down gated by a boolean flag disabled by default?

@rycee
Copy link
Member

rycee commented Jan 25, 2019

@kalbasit Yeah, that's sort of what I meant by restricting it to state version 19.03 or later. So for people having the state version set to 18.09 it would keep installing to ~/.nix-profile.

@kalbasit
Copy link
Collaborator

kalbasit commented Feb 8, 2019

@rycee Let's do that then, I would love to try it out on my daily driver as opposed to dedicate time for testing it.

@rycee
Copy link
Member

rycee commented Feb 9, 2019

I've started working on this and it should be quite doable. I could give you a deadline for when it's ready but then I'd also have to tell you that I most likely would break the deadline 😉

@rycee
Copy link
Member

rycee commented Feb 11, 2019

See #580 for a PR that supports both ~/.nix-profile and /etc/profiles installation. You need to add

home-manager.useUserPackages = true;

to your NixOS configuration to enable installation into /etc/profiles. I've tested this a bit locally but not super extensively so don't move to this branch when you have important other work to do 🙂

@kalbasit
Copy link
Collaborator

@rycee you're awesome, thank you! I'll try it on the way to work tomorrow!

@maralorn
Copy link
Contributor Author

I just went ahead and deployed this on my productive system. Seems to work for me.

I am just a bit curious, why we need the boolean flag. Does anyone have the home-manager/nixos module included in their system configuration.nix without using the /etc/profiles installation?

I am not against that option it makes sense to have it. With it it would it even be possible to merge this into nixpkgs. But I don't understand why not having this option would break anyone's setup when merging into master. It is my understanding that the features in this branch shouldn't affect users installing via home-manager switch at all.

@rycee
Copy link
Member

rycee commented Feb 12, 2019

@kalbasit Glad you like it, hope it works well for you!

@maralorn Good to head that it worked! I wanted the boolean flag because I don't entirely trust the /etc/profiles installs, for example, I had issues with Qt programs when I tried it. Also I imagine some users have scripts and such that include references into ~/.nix-profile and I want to avoid breaking that if possible.

@rycee
Copy link
Member

rycee commented Feb 16, 2019

In master now 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants