home-manager: Add allowOther option to let other users read bind mounts
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Jan 25, 2021
| example = true; | ||
| apply = x: | ||
| if x == null then | ||
| warn '' |
There was a problem hiding this comment.
Is it necessary to display this warning? Why not just default to false?
There was a problem hiding this comment.
It's not strictly necessary, no. It's mainly that I think most people would want to set it to true, but probably don't know it. Essentially, we can't set it to the sane default, since it clashes with the default NixOS configuration.
lovesegfault
approved these changes
Jan 26, 2021
talyz
force-pushed
the
bindfs-allow-other
branch
from
109573b
to
dcb4220
Compare
…unts NixOS defaults to not letting fuse mounts be allowed to let other users read their contents. `bindfs` wants to give other users access and is therefore normally run with `--no-allow-other` to not throw an error. Giving other users, mainly `root`, access to the bind mounts is, however, useful and works fine when programs.fuse.userAllowOther = true; is declared in `configuration.nix`. This adds an option to choose whether to give other users access or not. It also prompts the user to set the `allowOther` attribute with a link to the documentation.
talyz
force-pushed
the
bindfs-allow-other
branch
from
d391eba
to
4d655d7
Compare
The checks should be unnecessary, since `mkdir -p` is idempotent.
This is purely for convenience when fiddling with the services manually, since the directory is created by the activation script already.
lovesegfault
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NixOS defaults to not letting fuse mounts be allowed to let other users read their contents.
bindfswants to give other users access and is therefore normally run with--no-allow-otherto not throw an error.Giving other users, mainly
root, access to the bind mounts is, however, useful and works fine whenis declared in
configuration.nix. This adds an option to choose whether to give other users access or not. It also prompts the user to set theallowOtherattribute with a link to the documentation.Should be merged after #38.
Fixes #35