nixos: Minimize activation script debug, add debugging, and more #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the currently set bash options, set `noglob` and `inherit_errexit`. - `noglob` disables filename expansion, which could happen in the for loop where we do path splitting if the path contains characters recognized by bash as wildcards, such as `?` or `*`. - `inherit_errexit` makes subshells inherit the status of the `errexit` option.
This is done to reduce the risk of build errors, isolate each run of the script and reduce the amount of replicated code. - Make the file mount script generated by `mkMountScript` a discrete script and only generate its invocations. - Wrap the script invocations in scripts.
talyz
changed the title
This was referenced Feb 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixos: Minimize the amount of text added to the activation script
This is done to reduce the risk of build errors, isolate each run of the script and reduce the amount of replicated code.
Make the file mount script generated by
mkMountScripta discrete script and only generate its invocations.Wrap the script invocations in scripts.
Fixes #77, #78
nixos: Add an internal debugging option to aid script debugging
This should let users provide detailed traces of script errors.
create-directories: Set noglob and inherit_errexit, document options
In addition to the currently set bash options, set
noglobandinherit_errexit.noglobdisables filename expansion, which could happen in the for loop where we do path splitting if the path contains characters recognized by bash as wildcards, such as?or*.inherit_errexitmakes subshells inherit the status of theerrexitoption.