build01: add initial marvin-mk2 configuration #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Mic92
reviewed
Jun 10, 2020
build01/marvin-mk2.nix
Outdated
| # FIXME | ||
| environment.GH_KEY_FILE = ""; | ||
| # FIXME | ||
| environment.GH_APP_ID_FILE = ""; |
There was a problem hiding this comment.
By the way you can use EnvironmentFile to pass secrets from a file.
There was a problem hiding this comment.
That's quite nice. Potentially it means that the secret could even be owned by root isn't it?
I had a quick look at the EnvironmentFile documentation but it doesn't mention what user it will use to read the file.
There was a problem hiding this comment.
Having it owned by root might be nice, but since its exposed in the environment anyways the security benefits are probably marginal.
Mic92
reviewed
Jun 10, 2020
zimbatm
reviewed
Jun 11, 2020
timokau
force-pushed
the
marvin-mk2-init
branch
6 times, most recently
from
d9ed244
to
aee6b2a
Compare
timokau
force-pushed
the
marvin-mk2-init
branch
5 times, most recently
from
827d900
to
0d07cd7
Compare
timokau
force-pushed
the
marvin-mk2-init
branch
2 times, most recently
from
03a1d78
to
3aef26e
Compare
adisbladis
force-pushed
the
marvin-mk2-init
branch
from
7ddd0e8
to
5fdaff1
Compare
|
Thanks @adisbladis for all your help 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding marvin-mk2, see #24.
This is a work in progress.