Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure to be runnable as a GitHub action #11

Closed
delroth opened this issue Sep 10, 2023 · 4 comments
Closed

Restructure to be runnable as a GitHub action #11

delroth opened this issue Sep 10, 2023 · 4 comments

Comments

@delroth
Copy link
Collaborator

delroth commented Sep 10, 2023

There are several drawbacks to the current "crawling" approach used by this tool:

  • Easily runs into quota issues
  • Can't process more than the last 1K PRs by ID (due to GH search API limitations, maybe?)
  • High latency since the whole set of open PRs needs to be recrawled on every run

I suggest the following complementary mode of operation:

  • Add a mode to run only on one PR, whose ID is provided on the command line.
  • Add all the scaffolding to be able to run this tool as a GitHub action.
  • Register this action to run on PR review events on nixpkgs.

Happy to take care of this myself (want to share commit privileges / future maintenance? :p), I really just want this to finally happen automatically on nixpkgs.

@Artturin
Copy link
Member

I added you as as collaborator with maintainer level permissions

@delroth
Copy link
Collaborator Author

delroth commented Sep 10, 2023

Thanks! Do you still want to review those changes or are you giving me the green light to commit straight to master / self-merge?

@Artturin
Copy link
Member

You can self merge

A few things to keep in mind

The program should stay runnable without the action
And it should eventually be runnable on non-nixpkgs repos

delroth added a commit to delroth/label-approved that referenced this issue Sep 13, 2023
delroth added a commit to delroth/label-approved that referenced this issue Sep 13, 2023
delroth added a commit to delroth/label-approved that referenced this issue Sep 13, 2023
delroth added a commit to delroth/label-approved that referenced this issue Sep 13, 2023
delroth added a commit to delroth/label-approved that referenced this issue Oct 31, 2023
delroth added a commit to delroth/label-approved that referenced this issue Oct 31, 2023
delroth added a commit to delroth/label-approved that referenced this issue Oct 31, 2023
@delroth
Copy link
Collaborator Author

delroth commented Oct 31, 2023

Pushed everything needed so this can be used as nix-community/label-approved@v1 in GH actions. NixOS/nixpkgs#264633 is the nixpkgs side of things to start using this action, then I can stop running the bot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants