tool: improve sd-boot generation display name #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikstur
changed the title
|
@nikstur Looks good. Can you rebase? |
Leverage the bootspec `label` field in its intended way. The VERSION_ID of the os-release in the stub now only contains the generation number and the build time. This makes a correct PRETTY_NAME entirely dependent on correct information in the bootspec `label` field.
nikstur
force-pushed
the
improve-generation-name
branch
from
52b0876
to
a8d9ea1
Compare
|
I'll take that as an approval and merge it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the bootspec
labelfield in its intended way. The VERSION_IDof the os-release in the stub now only contains the generation number
and the build time. This makes a correct PRETTY_NAME entirely dependent
on correct information in the bootspec
labelfield.This should yield a display name similar to this:
NixOS Stoat 23.05 (Linux 6.1.9) (Generation 85, Built on 2023-02-01)Depends on #100
Closes #99