tool: correctly update initrd secrets #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikstur
force-pushed
the
correctly-update-initrd-secrets
branch
from
ce1db97
to
068f5e1
Compare
This was referenced Feb 20, 2023
nikstur
changed the title
|
Thx, good catch ;) |
To correctly overwrite existing initrd with newer secrets (from newer generations), the links need to be sorted from oldest generation to newest.
nikstur
force-pushed
the
correctly-update-initrd-secrets
branch
from
068f5e1
to
c4c78a9
Compare
Add a test for updating the secrets on an existing initrd.
nikstur
force-pushed
the
correctly-update-initrd-secrets
branch
from
c4c78a9
to
f4f8c41
Compare
|
Thanks for the reviews @blitz and @RaitoBezarius. I'm happy that we got these reviewed and merged quickly! |
Thank you for your work and patience :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a larger series which is supposed to be merged in order but is broken up into multiple pieces to make review easier. It is supposed to be merged in this order:
#108 -> #107 -> #110 -> (#109)
To correctly overwrite existing initrd with newer secrets (from newer
generations), the links need to be sorted from oldest generation to
newest.
Closes #103
Depends on #110