-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimalistic Logging Support #112
Conversation
I think a separate PR makes more sense. |
While I agree that added complexity is not desirable, moving forward with lanzaboote will expose it to various users and we will definitely encounter the need for runtime log level changes IMHO because users will not have an easy way to "enable a debug build" of lzbt in their state. So I am okay with this change as-is, because it's a move in the right direction (logging rather than no logging), but I am not satisfied with "no runtime modification". I don't know when is the right moment to introduce it, so if you have a plan @blitz or if you think we need to have a formal discussion on it and track this feature, let's do it. :) |
I'm not so sure. But time will tell. :)
Fair enough. Let's cross this bridge when we get there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just to make sure: are you speaking about the stub or the tool? I think the tool definetely needs configurable logging at some point but the stub does not. Does systemd-stub have configurable logging? From what I can tell it doesn't. |
The stub.
It does not have, but also, there are issues such as systemd/systemd#25911 where I do think configurable debugging will make easier bug reports. Anyway, I am fine with revisiting this once we hit enough usage that it becomes useful. |
This PR is an alternative to #87. The end result is the same: When everything goes well, lanzaboote gives no output (fixing #84).
The approach is different in that we don't allow any runtime modification of logging level. The release build will only print warnings and errors. I think too much configurability is not really helping and just introduces complexity which we can avoid.
Closes #84.