nixos-module: add settings key for the loader.conf #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am actually happy with the changes, I just need to run the CI locally because you're a new contributor. :) |
This commit adds settings key for configuring systemd-boot to the lanzaboot nixos module. The are couple of the default values that are set from the usual nixos boot.loader.systemd-boot options, they are merged with the user defined configuration. This commit modifies default loader.conf to boot into the latest nixos generation by default, for when you have other operating systems installed. Primary reason behind this PR is to allow extensible loader configuration. Co-authored-by: Raito Bezarius <masterancpp@gmail.com>
|
I fixed the tests and some formatting stuff, good to go for me. |
RaitoBezarius
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds settings key for configuring systemd-boot to the lanzaboot nixos module. The are couple of the default values that are set from the usual nixos boot.loader.systemd-boot options, they are merged with the user defined configuration.
This commit modifies default loader.conf to boot into the latest nixos generation by default, for when you have other operating systems installed.
Primary reason behind this PR is to allow extensible loader configuration.
This closes #133
Is this too complicated? What do you think?