Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable synthesis support #163

Merged
merged 1 commit into from
Apr 29, 2023
Merged

feat: enable synthesis support #163

merged 1 commit into from
Apr 29, 2023

Conversation

RaitoBezarius
Copy link
Member

Bootspec has a mechanism called synthesis where you can synthesize bootspecs if they are not present based on the generation link only.

This is useful for "vanilla bootspec" which does not contain any extensions, as this is what we do right now.

If we need extensions, we can also implement our synthesis mechanism on the top of it.

Enabling synthesis gives us the superpower to support non-bootspec users. :-)

rust/tool/src/generation.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Left some nits but overall this PR improves the status quo.

rust/tool/src/generation.rs Outdated Show resolved Hide resolved
rust/tool/src/generation.rs Outdated Show resolved Hide resolved
nix/tests/lanzaboote.nix Outdated Show resolved Hide resolved
nix/tests/lanzaboote.nix Outdated Show resolved Hide resolved
rust/tool/src/generation.rs Show resolved Hide resolved
rust/tool/src/generation.rs Outdated Show resolved Hide resolved
@RaitoBezarius RaitoBezarius force-pushed the synthesis branch 2 times, most recently from 341c80a to 0514a41 Compare April 29, 2023 20:01
Bootspec has a mechanism called synthesis where you can synthesize
bootspecs if they are not present based on the generation link only.

This is useful for "vanilla bootspec" which does not contain any
extensions, as this is what we do right now.

If we need extensions, we can also implement our synthesis mechanism on
the top of it.

Enabling synthesis gives us the superpower to support non-bootspec
users. :-)
@RaitoBezarius RaitoBezarius merged commit 64b903c into master Apr 29, 2023
2 checks passed
@RaitoBezarius RaitoBezarius deleted the synthesis branch April 29, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants