Better flake error msg #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyarly
requested changes
Jun 2, 2022
There was a problem hiding this comment.
I think this is 100% better than the nothing we have now. Could you update against canon, please, and I'd be inclined to merge.
One thing I note (and post-merge I'd open an issue for this): using this shim, lorri doesn't track the flake.nix or flake.lock. Until lorri supports flakes natively, a shim that somehow registered them would be amazing.
If you have immediate ideas about that, feel free to incorporate them
|
@gilescope Are you still inclined to get this merged? |
|
Back from holidays. Sure, have updated it @nyarly - let me know if there's any other changes needed before merge. |
|
Thanks, @gilescope ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we don't have native support for flakes yet this PR suggests the workaround suggested in target/lorri#460 if and only if there's no shell.nix and there's a flake.nix found.
I thought about creating the file automatically but I think just suggesting it is nicer.